Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/987 allow using --like option similar to SQL's LIKE logic #1006

Merged
merged 9 commits into from
Jun 29, 2023
Merged

Feature/987 allow using --like option similar to SQL's LIKE logic #1006

merged 9 commits into from
Jun 29, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jun 27, 2023 •
edited
Loading

PR details

What changes did you make? (Give an overview)

to-do

  • retrieve
  • execute

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (via [TASK] Documentation for 5.2 #1007)

@JoernBerkefeld JoernBerkefeld added this to the 5.2.0 milestone Jun 27, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jun 27, 2023
@JoernBerkefeld JoernBerkefeld marked this pull request as draft June 27, 2023 22:00
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Jun 27, 2023
@JoernBerkefeld
Copy link
Contributor Author

need to come up with a good test for this.

@github-actions
Copy link

github-actions bot commented Jun 27, 2023 •
edited
Loading

Coverage Report

Commit:1d3cf0f
Base: develop@d77fbc2

Type Base This PR
Total Statements Coverage  46.09%  46.39%  (+0.3%)
Total Branches Coverage  36.94%  37.4%  (+0.46%)
Total Functions Coverage  53.09%  53.2%  (+0.11%)
Total Lines Coverage  46.01%  46.32%  (+0.31%)
Details (changed files):
File Statements Branches Functions Lines
lib/cli.js  0%  0%  0%  0%
lib/index.js  47.34%  42.79%  53.84%  47.34%
lib/metadataTypes/MetadataType.js  63.85%  62.84%  73.49%  63.65%
lib/util/util.js  60.23%  51.8%  74%  60.16%

@JoernBerkefeld JoernBerkefeld changed the title Feature/987 instead of using key allow using filter similar to sqls like logic Feature/987 allow using filter similar to sqls like logic Jun 27, 2023
@JoernBerkefeld JoernBerkefeld changed the title Feature/987 allow using filter similar to sqls like logic Feature/987 allow using filter similar to sql's LIKE logic Jun 27, 2023
@JoernBerkefeld JoernBerkefeld linked an issue Jun 27, 2023 that may be closed by this pull request
[FEATURE] allow using --like option similar to SQL's LIKE logic #987
Closed
7 tasks
@JoernBerkefeld JoernBerkefeld changed the title Feature/987 allow using filter similar to sql's LIKE logic Feature/987 allow using --like option similar to SQL's LIKE logic Jun 27, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 28, 2023
View reviewed changes
lib/index.js
for (const originalKey in metadataMap) {
// hide postRetrieveOutput
Util.setLoggingLevel({ silent: true });
metadataMap[originalKey] = MetadataTypeInfo[selectedType].postRetrieveTasks(

Check warning

Code scanning / CodeQL

Prototype-polluting assignment

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from [library input](1).
@JoernBerkefeld
Copy link
Contributor Author

works for retrieve & execute now. added tests for both as well

@JoernBerkefeld JoernBerkefeld marked this pull request as ready for review June 29, 2023 12:45
@JoernBerkefeld JoernBerkefeld merged commit aa3701d into develop Jun 29, 2023
@JoernBerkefeld JoernBerkefeld deleted the feature/987-instead-of-using-key-allow-using-filter-similar-to-sqls-like-logic branch June 29, 2023 16:45
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougMidgley DougMidgley Awaiting requested review from DougMidgley

Assignees

@JoernBerkefeld JoernBerkefeld

Labels
enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] allow using --like option similar to SQL's LIKE logic
1 participant
@JoernBerkefeld